Skip to content

Python: Use import python consistently in all queries.#2448

Merged
semmle-qlci merged 1 commit into
github:masterfrom
tausbn:python-use-import-python-consistently
Nov 28, 2019
Merged

Python: Use import python consistently in all queries.#2448
semmle-qlci merged 1 commit into
github:masterfrom
tausbn:python-use-import-python-consistently

Conversation

@tausbn

@tausbn tausbn commented Nov 26, 2019

Copy link
Copy Markdown
Contributor

The Python counterpart to #2447. I want to run a performance comparison before merging this, to see if it improves performance for the queries involved.

@tausbn tausbn added WIP This is a work-in-progress, do not merge yet! Python labels Nov 26, 2019
@tausbn tausbn requested a review from a team as a code owner November 26, 2019 16:41
@RasmusWL

Copy link
Copy Markdown
Member

performance looks fine, no changes: https://git.semmle.com/gist/rasmuswl/aa914e39858410ef1cf90d830820272f

@tausbn

tausbn commented Nov 28, 2019

Copy link
Copy Markdown
Contributor Author

Performance comparison looks good: https://git.semmle.com/gist/taus/1b0f83bfe9970d77d486ecddc34349ad

@tausbn tausbn removed the WIP This is a work-in-progress, do not merge yet! label Nov 28, 2019
@semmle-qlci semmle-qlci merged commit 2b0eef3 into github:master Nov 28, 2019
@tausbn tausbn deleted the python-use-import-python-consistently branch February 12, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants